UI bug fix: Kubernetes Role filter replace with explicit input filter #27178
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
| // On escape, transition to roles index route. | ||
| this.navigate(); | ||
| } | ||
| // ignore all other key events |
There was a problem hiding this comment.
this is slick! nice job including keyboard navigation here. 😀
There was a problem hiding this comment.
This originally comes from Chelsea's refactor of an old filter input for Kv (see KvListFilter). All the credit goes to her :)
| @text="Search" | ||
| @icon="search" | ||
| type="submit" | ||
| {{on "click" @handleSearch}} |
There was a problem hiding this comment.
Is there a reason we aren't wrapping these in a <form> element so that clicking this button submits (and then we also get a free submit when the user presses the "Enter" button)? I think that would be a nice ergonomic update to this.
There was a problem hiding this comment.
The tests 😵💫 I originally had it wrapped as a form, but couldn't call the action correctly from the tests. There was an error about it being in a form element. I wish I would have saved that specific error. Let me see if I can resurface it. The enter functionality would be very nice!
There was a problem hiding this comment.
@hashishaw This was the error, any thoughts? Only on the test, not on the UI.
There was a problem hiding this comment.
oh, we just need to do evt.preventDefault in the triggered action so that it doesn't "send" the form data to the URL
There was a problem hiding this comment.
Got it! Found an example in how we do it for sinon spies in toggle-test (thank you—you did that block of code).
| @@ -20,6 +20,8 @@ export const GENERAL = { | |||
|
|
|||
| filter: (name: string) => `[data-test-filter="${name}"]`, | |||
| filterInput: '[data-test-filter-input]', | |||
| filterInputExplicit: '[data-test-filter-input-explicit]', | |||
Because this is a template only component, I think the parent who uses it could handle the directory structure search in the actions passed in. My thought was it could be used for any kind of odd routing situation, because it's the parents responsibility to handle the actions. Thoughts? |
The UI team has run into various issues with the use of
NavigateInputfor filtering over a list. Such an issue arose in the Kubernetes Secret Engine, and instead of trying to solve for that component, we moved forward with using the new explicit search pattern.This PR fixes Issue #27153
Note:
filterInputcomponent, but as the naming suggests is an explicit filter.NavigateInputa hard component to read — it's doing too much individualized tasks).NavigateInputshould also move towards this adoption. I'll write a JIRA ticket for this.Before
Screen.Recording.2024-05-22.at.10.54.53.AM.mov
After
k8after.mov